[libvirt] [PATCHv2 00/13] list all snapshots

Eric Blake eblake at redhat.com
Fri Jun 15 04:18:25 UTC 2012


This is a v2 of the remaining patches in:
https://www.redhat.com/archives/libvir-list/2012-June/msg00273.html
https://www.redhat.com/archives/libvir-list/2012-June/msg00284.html

It assumes that Peter's list all domain patches have been applied
already, at least through patch 6/12:
https://www.redhat.com/archives/libvir-list/2012-June/msg00316.html

In other words, this series will not apply to current libvirt.git
at the time of this mail.  And since I developed against v3 of Peter's
patches and he has some tweaks to make, I will probably have to make
minor tweaks to rebase on top of his eventual v4.  I will follow up
with a link to a git repo with Peter's v3 and my series, and/or my
rebase on top of his v4.

Overall changes since v1:
actually tested this time
address review comments
lots of bug fixes due to corner case testing
rearrange the patch series so that metaroot comes before filtering
pick up some good ideas from Peter's v3

More details in some of the individual patches, if I can remember
everything I did.

In particular, I'm quite pleased that the overall diffstat for
domain_conf.c reduced in size in spite of adding features :)

Eric Blake (13):
  snapshot: new virsh function factored from snapshot-list
  snapshot: use new virsh function for snapshot-list
  snapshot: use metaroot node to simplify management
  snapshot: merge domain and snapshot computation
  snapshot: merge count and name collectoin
  snapshot: add additional filters when getting lists
  snapshot: expose new flags in virsh
  list: add virDomainListAllSnapshots API
  list: use the new snapshot API in virsh when possible
  list: provide python bindings for snapshots
  list: provide RPC call for snapshots
  list: new helper function to collect snapshots
  list: add qemu snapshot list support

 daemon/remote.c                              |  126 ++++++
 include/libvirt/libvirt.h.in                 |   35 +-
 python/Makefile.am                           |    2 +
 python/generator.py                          |    2 +
 python/libvirt-override-api.xml              |   16 +-
 python/libvirt-override-virDomain.py         |   11 +
 python/libvirt-override-virDomainSnapshot.py |   11 +
 python/libvirt-override.c                    |   92 +++++
 src/conf/domain_conf.c                       |  250 ++++-------
 src/conf/domain_conf.h                       |   19 +-
 src/conf/virdomainlist.c                     |   44 +-
 src/conf/virdomainlist.h                     |   18 +
 src/driver.h                                 |   12 +
 src/libvirt.c                                |  275 +++++++++++--
 src/libvirt_private.syms                     |    3 +-
 src/libvirt_public.syms                      |    2 +
 src/qemu/qemu_driver.c                       |  137 +++++--
 src/qemu/qemu_migration.c                    |    3 +-
 src/remote/remote_driver.c                   |  126 ++++++
 src/remote/remote_protocol.x                 |   26 +-
 src/remote_protocol-structs                  |   26 ++
 tools/virsh.c                                |  570 +++++++++++++++++---------
 tools/virsh.pod                              |   14 +-
 23 files changed, 1371 insertions(+), 449 deletions(-)
 create mode 100644 python/libvirt-override-virDomain.py
 create mode 100644 python/libvirt-override-virDomainSnapshot.py

-- 
1.7.10.2




More information about the libvir-list mailing list