[libvirt] [PATCHv3 06/12] conf: Add helper for listing domains on drivers supporting virDomainObj

Peter Krempa pkrempa at redhat.com
Mon Jun 18 19:30:11 UTC 2012


On 06/14/12 01:36, Eric Blake wrote:
> On 06/11/2012 04:34 AM, Peter Krempa wrote:
>>
>> This patch adds common code to list domains in fashion used by
>> virListAllDomains with all currently supported flags. The header file
>> also contains macros that group filters together that are used to
>> shorten filter conditions.
>> ---
>> Diff to v2:
>> -added macros grouping filter flags
>> -Added support for managed save filtering, now that virDomainObj holds this property
>> - Removed the now unneeded filtering function
>> - Changed allocation of the return list, now It's allocated before for the full
>>   length and it's trimmed afterwards
>> - Added newline after the DOMAIN_LIST_SOURCES definition in Makefile.am
>> ---
>>   src/Makefile.am          |    8 ++-
>>   src/conf/virdomainlist.c |  182 ++++++++++++++++++++++++++++++++++++++++++++++
>>   src/conf/virdomainlist.h |   66 +++++++++++++++++
>>   src/libvirt_private.syms |    4 +
>>   4 files changed, 259 insertions(+), 1 deletions(-)
>>   create mode 100644 src/conf/virdomainlist.c
>>   create mode 100644 src/conf/virdomainlist.h


> ACK with comment fix.

Fixed && pushed.

Thanks.

Peter




More information about the libvir-list mailing list