[libvirt] [PATCH] openvz: Fix wordsize on 64 bit architectures

Guido Günther agx at sigxcpu.org
Tue Jun 19 07:11:57 UTC 2012


On Mon, Jun 18, 2012 at 03:08:39PM -0600, Eric Blake wrote:
> On 06/17/2012 11:18 AM, Guido Günther wrote:
> > The word size there is 64 bit not 8.
> > ---
> > Came across this while browsing the source. O.k. to apply?
> >  -- Guido
> > 
> >  src/openvz/openvz_conf.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/src/openvz/openvz_conf.c b/src/openvz/openvz_conf.c
> > index ad4ed74..007f9fe 100644
> > --- a/src/openvz/openvz_conf.c
> > +++ b/src/openvz/openvz_conf.c
> > @@ -195,7 +195,7 @@ virCapsPtr openvzCapsInit(void)
> >      if ((guest = virCapabilitiesAddGuest(caps,
> >                                           "exe",
> >                                           utsname.machine,
> > -                                         sizeof(int) == 4 ? 32 : 8,
> > +                                         sizeof(int) == 4 ? 32 : 64,
> 
> Do we ever compile openvz on any platform where sizeof(int) = 4?
> Shouldn't this really be checking sizeof(long)?

Or the actual pointer size? Patch attached.
Cheers,
 -- Guido

> 
> -- 
> Eric Blake   eblake at redhat.com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
> 
> 
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-openvz-check-pointer-size-instead-of-int.patch
Type: text/x-diff
Size: 1135 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120619/7c163b53/attachment-0001.bin>


More information about the libvir-list mailing list