[libvirt] [PATCH] domain_conf: fix possible memory leak
Martin Kletzander
mkletzan at redhat.com
Tue Jun 19 16:21:39 UTC 2012
On 06/19/2012 03:55 PM, Michal Privoznik wrote:
> On 19.06.2012 14:07, Martin Kletzander wrote:
>> Until now, it was possible to crash libvirtd when defining domain with
>> channel device with missing source element.
>>
>> When creating new virDomainChrDef, target.port is set to -1, but
>> unfortunately it is an union with addresses that virDomainChrDefFree
>> tries to free in case the deviceType is channel. Having the port set
>> to -1 is intended, however the cleanest way to get around the problems
>> with the crash seems to be renumbering the VIR_DOMAIN_CHR_CHANNEL_
>> target types to cover new NONE type (with value 0) being the default
>> (no target type yet).
>> ---
>> src/conf/domain_conf.c | 1 +
>> src/conf/domain_conf.h | 3 ++-
>> 2 files changed, 3 insertions(+), 1 deletions(-)
>>
>
> ACK
>
> Michal
>
Thanks, pushed
Martin
More information about the libvir-list
mailing list