[libvirt] [PATCHv3 07/12] drivers: Implement virListAllDomains for drivers using virDomainObj

Peter Krempa pkrempa at redhat.com
Wed Jun 20 11:48:10 UTC 2012


On 06/18/12 21:01, Eric Blake wrote:
> On 06/11/2012 04:34 AM, Peter Krempa wrote:
>> This patch adds support for listing all domains into drivers that use
>> the common virDomainObj implementation: libxl, lxc, openvz, qemu, test,
>>      uml, vmware.
>>
>> For drivers that don't support managed save images the guests are
>> treated as if they had none, so filtering guests that do have such an
>> image on this driver succeeds and produces 0 results.
>> ---
>> Diff to v2:
>> - removed driver specific checks now that they're not needed
>> - changed flag check to use new macros
>> - reordered assignment of the function pointer do driver struct
>> ---
>
> Is it worth listing this line next to the other listing callbacks?
>
> ACK with the libxl bug fixed.
>

I've fixed the libxl flag checking and reordered the callback 
registration in lxc and pushed. Thanks

Peter





More information about the libvir-list mailing list