[libvirt] [PATCH] Initialize random generator in lxc controller

Daniel P. Berrange berrange at redhat.com
Thu Jun 21 09:33:49 UTC 2012


On Thu, Jun 21, 2012 at 12:50:41PM +0800, Osier Yang wrote:
> On 2012年06月21日 12:28, Jim Fehlig wrote:
> >I'm having some problems sending patches to the list via git
> >send-email.  The messages are being delivered to my MTA afaict, and I
> >can send patches to my personal and corporate accounts.  Until I get
> >this resolved, attaching a patch to fix a segfault in libvirt_lxc.
> >
> 
> ACK. Seems nobody tried nwfilter for lxc, otherwise it should be
> exposed much earlier.

Well more correctly, nwfilter with LXC did work fine, until we changed
the hash table impl to use the random number generator.

Really, we need to purge all these manual initializers IMHO, and use
the virThreadOnce initializers which guarentee once-only, first time
of use initialization

ACK to Jim's patch anyway though

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the libvir-list mailing list