[libvirt] [PATCH] Fix unused parameters / functions in virsh on Win32
Eric Blake
eblake at redhat.com
Fri Jun 22 04:30:44 UTC 2012
On 06/21/2012 07:47 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange at redhat.com>
>
> The vshPrintRaw function is not used on Win32, and neither
> is the 'msg' parameter of vshAskReedit. Change the nesting
> of #ifdef WIN32 conditionals to address this
> ---
> tools/virsh.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
ACK. However,.
> return c;
> +}
> #else
> +static int
> +vshAskReedit(vshControl *ctl, const char *msg ATTRIBUTE_UNUSED)
> +{
> vshDebug(ctl, VSH_ERR_WARNING, "%s", _("This function is not "
> "supported on WIN32 platform"));
> return 0;
> -#endif
> }
> +#endif
now that these are starting to get further away from the #if, it might
help to add a comment explaining what this #else and #endif pair to.
--
Eric Blake eblake at redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120621/22577e25/attachment-0001.sig>
More information about the libvir-list
mailing list