[libvirt] [PATCH v2 0/5] Introduce API for dumping domain IP addresses

Daniel P. Berrange berrange at redhat.com
Tue Jun 26 10:10:45 UTC 2012


On Thu, Jun 21, 2012 at 03:55:57PM +0200, Michal Privoznik wrote:
> This feature has been requested for a very long time. However,
> we had to wait for guest agent to obtain reliable results as
> user might create totally different structure of interfaces than
> seen from outside (e.g. bonding, virtual interfaces, etc.).
> That's the main reason why sniffing for domain traffic can
> return bogus results. Fortunately, qemu guest agent implement
> requested part for a while so nothing holds us back anymore.
> 
> To make matters worse, guest OS can assign whatever name to
> an interface and changing MAC inside guest isn't propagated
> to the host which in the end see original one.
> 
> Therefore, finding correlation between interface within guest
> and the host side end is left as exercise for mgmt applications.
> 
> This API is called virDomainGetInterfacesAddresses (okay, maybe
> too many plurals) and returns a XML document containing all
> interesting data.

As I mentioned before, I'm not really seeing a compelling need
or benefit for returning an XML document, instead of a struct.
I'd only see the point if we anticipated that this XML document
would expand to cover full interface config, as seen with netcf,
but in that case, I'd expect the XML document to follow the
network interface schema, rather than be a brand new schema.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the libvir-list mailing list