[libvirt] [Patch]: spice agent-mouse support
Daniel P. Berrange
berrange at redhat.com
Fri Mar 2 09:58:49 UTC 2012
On Fri, Mar 02, 2012 at 09:06:20AM +0800, Zhou Peng wrote:
> On Thu, Mar 1, 2012 at 5:32 PM, Daniel P. Berrange <berrange at redhat.com> wrote:
> > On Thu, Mar 01, 2012 at 11:54:30AM +0800, Zhou Peng wrote:
> >> Signed-off-by: Zhou Peng <zhoupeng at nfs.iscas.ac.cn>
> >>
> >> spice agent-mouse support
> >>
> >> diff --git a/tests/qemuxml2argvdata/qemuxml2argv-channel-spicevmc.xml b/tests/qemuxml2argvdata/qemuxml2argv-channel-spicevmc.xml
> >> index 6505b55..266a4ed 100644
> >> --- a/tests/qemuxml2argvdata/qemuxml2argv-channel-spicevmc.xml
> >> +++ b/tests/qemuxml2argvdata/qemuxml2argv-channel-spicevmc.xml
> >> @@ -23,7 +23,7 @@
> >> <controller type='virtio-serial' index='1'>
> >> <address type='pci' domain='0x0000' bus='0x00' slot='0x0a' function='0x0'/>
> >> </controller>
> >> - <graphics type='spice' port='5903' tlsPort='5904' autoport='no' listen='127.0.0.1'>
> >> + <graphics type='spice' port='5903' tlsPort='5904' autoport='no' listen='127.0.0.1' agentmouse='off'>
> >> <channel name='main' mode='secure'/>
> >> </graphics>
> >> <channel type='spicevmc'>
> >
> > Rather than adding an attribute 'agentmouse' I think it'd be preferrable
> > to use a sub-element:
> >
> > <agent mouse='on|off'/>
> >
> > that way if we have more configuration related to the agent we have
> > a nice place to put it
> I take note of the implemented clipboard sub-element..
> spice clipboard use agent too to implement copypaste like agentmouse.
> I realize your idea to separate is great in the long run and agree with
> you to use another sub-emement to describe,
> But I'm sorry I still don't agree with you to use
> <agent mouse='on|off'/>
>
> How about this way pls:
> <graphics type='spice' >
> <mouse mode='client|server'>
Yes this looks fine to me.
> ...
> <clipboard copypaste='yes|no'/>
> </graphics>
>
> Refering to qemu-spice's implement:
> There are two mouse modes at the moment that is
> SPICE_MOUSE_MODE_SERVER and SPICE_MOUSE_MODE_CLIENT
> Currently 'agent-mouse=on' equal to 'SPICE_MOUSE_MODE_CLIENT'
> 'agent-mouse=off' equal to 'SPICE_MOUSE_MODE_SERVER'
Yes, your idea makes sense in this context
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list