[libvirt] [libvirt-glib] Keep domain devices list sorted
Daniel P. Berrange
berrange at redhat.com
Wed Mar 7 08:13:02 UTC 2012
On Wed, Mar 07, 2012 at 12:27:53AM +0200, Zeeshan Ali (Khattak) wrote:
> From: "Zeeshan Ali (Khattak)" <zeeshanak at gnome.org>
>
> While we don't guarantee the order of devices in the list returned from
> gvir_domain_get_devices(), its not a bad idea to keep them sorted the
> same way we get them from configuration (XML).
> ---
> libvirt-gobject/libvirt-gobject-domain.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/libvirt-gobject/libvirt-gobject-domain.c b/libvirt-gobject/libvirt-gobject-domain.c
> index 7b2c7ad..0bafa7e 100644
> --- a/libvirt-gobject/libvirt-gobject-domain.c
> +++ b/libvirt-gobject/libvirt-gobject-domain.c
> @@ -909,5 +909,5 @@ GList *gvir_domain_get_devices(GVirDomain *domain,
> }
> g_list_free (config_devices);
>
> - return ret;
> + return g_list_reverse (ret);
> }
ACK
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list