[libvirt] [PATCH] util: log error on OOM in virNetDevOpenvswitchAddPort

Eric Blake eblake at redhat.com
Thu Mar 8 19:00:43 UTC 2012


On 03/08/2012 11:58 AM, Laine Stump wrote:
> OOM conditions silently returned failure.
> ---
>  src/util/virnetdevopenvswitch.c |   12 ++++++++----
>  1 files changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/src/util/virnetdevopenvswitch.c b/src/util/virnetdevopenvswitch.c
> index e2d5124..61bb9e1 100644
> --- a/src/util/virnetdevopenvswitch.c
> +++ b/src/util/virnetdevopenvswitch.c
> @@ -64,17 +64,17 @@ int virNetDevOpenvswitchAddPort(const char *brname, const char *ifname,
>  
>      if (virAsprintf(&attachedmac_ex_id, "external-ids:attached-mac=\"%s\"",
>                      macaddrstr) < 0)
> -        goto cleanup;
> +        goto out_of_memory;

ACK.

-- 
Eric Blake   eblake at redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120308/53167cc2/attachment-0001.sig>


More information about the libvir-list mailing list