[libvirt] [PATCH v3] Fixed NULL pointer check
Daniel P. Berrange
berrange at redhat.com
Mon Mar 19 10:42:12 UTC 2012
On Mon, Mar 19, 2012 at 11:05:30AM +0100, Martin Kletzander wrote:
> This patch fixes a NULL pointer check that was causing SegFault on
> some specific configurations. It also reverts commit 59d0c9801c1ab
> that was checking for this value in one place.
> ---
> v3:
> - added revert of 59d0c9801c1ab that's not needed anymore
>
> - (comment) ATTRIBUTE_RETURN_CHECK not added as it is not used with other
> functions defined in this file and the commit could be confusing modifying
> all of them together. However, there should be one patch to fix all these
> at once if possible
>
> v2:
> - removed parenthesis around return value
>
> src/libvirt.c | 3 +--
> src/util/conf.c | 5 ++++-
> 2 files changed, 5 insertions(+), 3 deletions(-)
ACK
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list