[libvirt] [test-API PATCH] utils: Make ipget.sh more portable

Guannan Ren gren at redhat.com
Wed Mar 21 17:15:53 UTC 2012


On 03/21/2012 10:53 PM, Peter Krempa wrote:
> Change the test for existence of nmap to be a little more cross-distro
> portable.
> ---
>   utils/ipget.sh |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/utils/ipget.sh b/utils/ipget.sh
> index cc1949b..8d44b14 100755
> --- a/utils/ipget.sh
> +++ b/utils/ipget.sh
> @@ -6,8 +6,8 @@ if [[ -z $mac ]]; then
>      exit 1
>   fi
>
> -if ! rpm -qa |grep -q nmap ;then
> -   echo "need nmap rpmball installed."
> +if ! type nmap>/dev/null 2>&1; then
> +   echo "nmap package needs to be installed."
>      exit 1
>   fi
>

    ACK ,thanks

    Guannan Ren




More information about the libvir-list mailing list