[libvirt] [PATCHv2] virsh: plug memory leaks on failure path

Eric Blake eblake at redhat.com
Wed Mar 28 12:04:20 UTC 2012


On 03/28/2012 02:43 AM, Alex Jia wrote:
> Leaks are introduced in commit 1cf0e3d and fe383bb.
> 
> Fixing memory leaks, in addition, the patch also fixs a potential missing 

s/fixs/fixes/

> return value issue in 'if (from)' statement, without the fixing, although 
> the programming met a error, the subsequent codes will be executed 
> continually.  
> 

> 
> 
> Signed-off-by: Alex Jia <ajia at redhat.com>
> ---
>  tools/virsh.c |    9 +++++----
>  1 files changed, 5 insertions(+), 4 deletions(-)

ACK.

-- 
Eric Blake   eblake at redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120328/dc2e4d1c/attachment-0001.sig>


More information about the libvir-list mailing list