[libvirt] [PATCHv2] virsh: plug memory leaks on failure path
Alex Jia
ajia at redhat.com
Wed Mar 28 15:01:31 UTC 2012
Thanks and pushed with s/fixs/fixes/ now.
----- Original Message -----
From: "Eric Blake" <eblake at redhat.com>
To: "Alex Jia" <ajia at redhat.com>
Cc: libvir-list at redhat.com
Sent: Wednesday, March 28, 2012 8:04:20 PM
Subject: Re: [libvirt] [PATCHv2] virsh: plug memory leaks on failure path
On 03/28/2012 02:43 AM, Alex Jia wrote:
> Leaks are introduced in commit 1cf0e3d and fe383bb.
>
> Fixing memory leaks, in addition, the patch also fixs a potential missing
s/fixs/fixes/
> return value issue in 'if (from)' statement, without the fixing, although
> the programming met a error, the subsequent codes will be executed
> continually.
>
>
>
> Signed-off-by: Alex Jia <ajia at redhat.com>
> ---
> tools/virsh.c | 9 +++++----
> 1 files changed, 5 insertions(+), 4 deletions(-)
ACK.
--
Eric Blake eblake at redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
More information about the libvir-list
mailing list