[libvirt] [PATCH] virnetdevtap: Don't check for flags in virNetDevTapCreateFlags

Eric Blake eblake at redhat.com
Fri Mar 30 13:04:59 UTC 2012


On 03/30/2012 05:49 AM, Michal Privoznik wrote:
> With latest gnulib we are checking even the lowest level functions
> whether they check flags. Moreover, we are shadowing the real error
> on system without TUNSETIFF support.
> ---
>  cfg.mk                  |    2 +-
>  src/util/virnetdevtap.c |    5 +----
>  2 files changed, 2 insertions(+), 5 deletions(-)
> 

> @@ -241,7 +239,6 @@ int virNetDevTapCreate(char **ifname ATTRIBUTE_UNUSED,
>                         int *tapfd ATTRIBUTE_UNUSED,
>                         unsigned int flags)

Missing the ATTRIBUTE_UNUSED here.  ACK with that fix.

-- 
Eric Blake   eblake at redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120330/f3257614/attachment-0001.sig>


More information about the libvir-list mailing list