[libvirt] [PATCH libvirt 3/3] build: update pid_t type static check
Eric Blake
eblake at redhat.com
Wed May 2 18:49:09 UTC 2012
On 04/20/2012 07:13 AM, Marc-André Lureau wrote:
> The code uses long long for pid_t now.
> It fails on mingw64 without this change.
> ---
> src/util/virpidfile.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/src/util/virpidfile.c b/src/util/virpidfile.c
> index 59d0c94..27811e1 100644
> --- a/src/util/virpidfile.c
> +++ b/src/util/virpidfile.c
> @@ -316,8 +316,7 @@ cleanup:
> return rc;
> }
>
> -
> -verify(sizeof(pid_t) <= sizeof(unsigned int));
> +verify(sizeof(pid_t) <= sizeof(long long));
All integers are smaller than 'long long' (well, I know that there is
work to add 128-bit integers, but you'd be crazy to make pid_t that
big). I'd rather just delete the assertion altogether. ACK with that
change, and pushed.
--
Eric Blake eblake at redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120502/670f743d/attachment-0001.sig>
More information about the libvir-list
mailing list