[libvirt] [PATCH libvirt 2/5] domain: add <codec> sound sub-element

[Eric Blake]

On 05/04/2012 11:22 AM, Marc-André Lureau wrote:
> Allow specifying sound device codecs. See formatdomain.html for
> more details.
> ---
>  docs/formatdomain.html.in     |   16 ++++++
>  docs/schemas/domaincommon.rng |   29 +++++++---
>  src/conf/domain_conf.c        |  119 ++++++++++++++++++++++++++++++++++++++++-
>  src/conf/domain_conf.h        |   20 +++++++
>  4 files changed, 176 insertions(+), 8 deletions(-)
> 
> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
> index e1fe0c4..3e4e42b 100644
> --- a/docs/formatdomain.html.in
> +++ b/docs/formatdomain.html.in
> @@ -3595,6 +3595,22 @@ qemu-kvm -net nic,model=? /dev/null
>      </dl>
>  
>      <p>
> +      Since 0.9.13, a sound element with <code>ich6</code> model can

Ah, I see that you are already planning on deferring this series until
post-0.9.12 release.  I'd put the "Since 0.9.13" text into the
appropriate <span> that we use for all our other versioning comments.

The rest of this patch (and indeed, the series as a whole) looked pretty
clean on my casual scan through it, although I probably won't review it
closely until after the release.

-- 
Eric Blake   eblake at redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120504/cfcd89e7/attachment-0001.sig>