[libvirt] [PATCH 3/3] qemu: Don't skip detection of virtual cpu's on non KVM targets
Eric Blake
eblake at redhat.com
Thu May 10 23:12:49 UTC 2012
On 05/07/2012 06:16 AM, Peter Krempa wrote:
> QEMU adapted the info cpus command from the kvm branch. This patch
> removes the check for the KVM domain type to detect virtualprocessors
> also while using software emulation.
Which version of qemu adopted the command? Do we need a capability bit
in qemu_capabilities.h to track whether the command exists and will be
reliable enough?
>
> The output of the "info cpus" command may vary across different targets
> but informations that are parsed by libvirt (cpu ID and thread pid) are
s/informations that are/information that is/
> (should be) present on those other targets too.
> ---
> src/qemu/qemu_process.c | 12 ------------
> 1 files changed, 0 insertions(+), 12 deletions(-)
>
Bug fix by deletion is always fun, but are we sure this works with, for
example, non-kvm qemu 0.12?
--
Eric Blake eblake at redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120510/0f1a5e0c/attachment-0001.sig>
More information about the libvir-list
mailing list