[libvirt] [PATCH v2] [TCK] nwfilter: Add test cases for ipset

[Stefan Berger]

On 04/27/2012 10:19 AM, Eric Blake wrote:
> On 04/27/2012 05:25 AM, Stefan Berger wrote:
>> Add test cases for ipset support.
>>
>> Since ipset may not be available on all system, the first line of the XML
>> file containing the test filter has been extended with a specially
>> formatted
>> XML comment containing a command line test for whether the test case can be
>> run at all. The format of that line is:
>>
>> <!-- #<command line test># -->
>>
>> If the tests in this line don't succeed, the test case is skipped.
>>
>> Also add a test case cleaning up the created ipset. Run this test after all
>> other tests using alphabetical ordering.
>>
>> ---
>>   v2:
>>    - addressed Eric Blake's comments
> ACK with one nit, and once the libvirt side is in:
>
>
>>     if [ ! -r "${xmlfile}" ]; then
> Here you are quoting, which means you are worried ${xmlfile} might
> contain spaces...
>
[...]
> ...so you must be consistent and also quote ${xmlfile} here.
>
I pushed this now with the nit fixed. Thanks for the review and the 
explanations about the 'eval .. 2>&1 1>/dev/null' scripting.

    Stefan