[libvirt] [PATCH V14 1/5] Introduce virMacAddr typedef
Eric Blake
eblake at redhat.com
Sat May 26 02:43:47 UTC 2012
On 05/25/2012 05:56 AM, Stefan Berger wrote:
> ---
> src/util/virmacaddr.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> Index: libvirt/src/util/virmacaddr.h
> ===================================================================
> --- libvirt.orig/src/util/virmacaddr.h
> +++ libvirt/src/util/virmacaddr.h
> @@ -30,6 +30,8 @@
> # define VIR_MAC_PREFIX_BUFLEN 3
> # define VIR_MAC_STRING_BUFLEN VIR_MAC_BUFLEN * 3
Not your fault, but this line is broken. It should be:
# define VIR_MAC_STRING_BUFLEN (VIR_MAC_BUFLEN * 3)
>
> +typedef unsigned char virMacAddr[VIR_MAC_BUFLEN];
> +
> int virMacAddrCompare(const char *mac1, const char *mac2);
> void virMacAddrFormat(const unsigned char *addr,
> char *str);
Simple enough. ACK with the additional fix.
--
Eric Blake eblake at redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120525/a1eedafc/attachment-0001.sig>
More information about the libvir-list
mailing list