[libvirt] [PATCH] qemu: configurable VNC port boundaries for domains
Daniel P. Berrange
berrange at redhat.com
Mon May 28 12:29:22 UTC 2012
On Tue, May 22, 2012 at 04:10:03PM +0200, Martin Kletzander wrote:
> The defines QEMU_VNC_PORT_MIN and QEMU_VNC_PORT_MAX were used to find
> free port when starting domains. As this was hardcoded to the same
> ports as default VNC servers, there were races with these other
> programs. This patch includes the possibility to change the default
> starting port as well as the maximum port in qemu config file.
>
> Support for two new config options in qemu.conf is added:
> * vnc_port_min (defaults to QEMU_VNC_PORT_MIN and must be >= than this
> value)
> * vnc_port_max (defaults to QEMU_VNC_PORT_MAX and must be <= than this
> value)
> ---
> src/qemu/qemu.conf | 7 +++++++
> src/qemu/qemu_command.h | 3 +++
> src/qemu/qemu_conf.c | 37 ++++++++++++++++++++++++++++++++++++-
> src/qemu/qemu_conf.h | 2 ++
> src/qemu/qemu_driver.c | 14 ++++++++------
> src/qemu/qemu_process.c | 20 ++++++++++----------
> 6 files changed, 66 insertions(+), 17 deletions(-)
NB, this is incomplete - you need to add the same configuration
support for SPICE port numbers.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list