[libvirt] [PATCHv2 0/4] double close() fixes
Eric Blake
eblake at redhat.com
Thu May 31 04:01:30 UTC 2012
On 05/30/2012 09:43 PM, Eric Blake wrote:
> Updated version of Wen's and my patches. In this version, I
> fixed review comments, split Wen's patch into 3, and tracked
> down when each bug was introduced.
>
> Eric Blake (2):
> command: avoid double close bugs
> fdstream: avoid double close bug
>
> Wen Congyang (2):
> command: check for fork error before closing fd
> qemu: avoid closing fd more than once
I've gone ahead and pushed this series. My patch 2/4 differs slightly
from Wen's 1/3 on his repost, but the principle is the same - transfer
semantics means that fds[] no longer need to be closed because another
variable tracks them. Meanwhile, my 1/4 fixed the only thing found
wrong by Wen in v1, and my 3/4 and 4/4 are identical to Wen's latest
repost with nicer commit messages.
--
Eric Blake eblake at redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120530/7a8f36d1/attachment-0001.sig>
More information about the libvir-list
mailing list