[libvirt] [PATCH v6 4/9] pvs: implement functions for domain life cycle management

Dmitry Guryanov dguryanov at parallels.com
Wed May 2 18:32:39 UTC 2012


Add functions for create/shutdown/destroy and suspend/resume domain.

Signed-off-by: Dmitry Guryanov <dguryanov at parallels.com>
---
changes in v6:
  * fix issue with POTFILES.in
  * fix error message in case domain us not found
  * make pvsPause/pvsResume/pvsStart/pvsStop/pvsShutdown static

 src/pvs/pvs_driver.c |  149 ++++++++++++++++++++++++++++++++++++++++++++++++++
 src/pvs/pvs_driver.h |    1 +
 src/pvs/pvs_utils.c  |   18 ++++++
 3 files changed, 168 insertions(+), 0 deletions(-)

diff --git a/src/pvs/pvs_driver.c b/src/pvs/pvs_driver.c
index e5a05e8..7863e46 100644
--- a/src/pvs/pvs_driver.c
+++ b/src/pvs/pvs_driver.c
@@ -59,6 +59,11 @@
 static void pvsFreeDomObj(void *p);
 static virCapsPtr pvsBuildCapabilities(void);
 static int pvsClose(virConnectPtr conn);
+static int pvsPause(virDomainObjPtr privdom);
+static int pvsResume(virDomainObjPtr privdom);
+static int pvsStart(virDomainObjPtr privdom);
+static int pvsKill(virDomainObjPtr privdom);
+static int pvsStop(virDomainObjPtr privdom);
 
 static void
 pvsDriverLock(pvsConnPtr driver)
@@ -84,6 +89,12 @@ pvsFreeDomObj(void *p)
     VIR_FREE(p);
 };
 
+static void
+pvsDomainEventQueue(pvsConnPtr driver, virDomainEventPtr event)
+{
+    virDomainEventStateQueue(driver->domainEventState, event);
+}
+
 static virCapsPtr
 pvsBuildCapabilities(void)
 {
@@ -761,6 +772,139 @@ pvsDomainGetAutostart(virDomainPtr domain, int *autostart)
     return ret;
 }
 
+typedef int (*pvsChangeState)    (virDomainObjPtr privdom);
+#define PVS_UUID(x)     (((pvsDomObjPtr)(x->privateData))->uuid)
+
+static int
+pvsDomainChangeState(virDomainPtr domain,
+                     virDomainState req_state, const char *req_state_name,
+                     pvsChangeState chstate,
+                     virDomainState new_state, int reason,
+                     int event_type, int event_detail)
+{
+    pvsConnPtr privconn = domain->conn->privateData;
+    virDomainObjPtr privdom;
+    virDomainEventPtr event = NULL;
+    int state;
+    int ret = -1;
+
+    pvsDriverLock(privconn);
+    privdom = virDomainFindByName(&privconn->domains, domain->name);
+    pvsDriverUnlock(privconn);
+
+    if (privdom == NULL) {
+        pvsError(VIR_ERR_NO_DOMAIN,
+                 _("no domain with matching name '%s'"), domain->name);
+        goto cleanup;
+    }
+
+    state = virDomainObjGetState(privdom, NULL);
+    if (state != req_state) {
+        pvsError(VIR_ERR_INTERNAL_ERROR, _("domain '%s' not %s"),
+                 privdom->def->name, req_state_name);
+        goto cleanup;
+    }
+
+    if (chstate(privdom))
+        goto cleanup;
+
+    virDomainObjSetState(privdom, new_state, reason);
+
+    event = virDomainEventNewFromObj(privdom, event_type, event_detail);
+    ret = 0;
+
+  cleanup:
+    if (privdom)
+        virDomainObjUnlock(privdom);
+
+    if (event) {
+        pvsDriverLock(privconn);
+        pvsDomainEventQueue(privconn, event);
+        pvsDriverUnlock(privconn);
+    }
+    return ret;
+}
+
+static int pvsPause(virDomainObjPtr privdom)
+{
+    return pvsCmdRun(PRLCTL, "pause", PVS_UUID(privdom), NULL);
+}
+
+static int
+pvsPauseDomain(virDomainPtr domain)
+{
+    return pvsDomainChangeState(domain,
+                                VIR_DOMAIN_RUNNING, "running",
+                                pvsPause,
+                                VIR_DOMAIN_PAUSED, VIR_DOMAIN_PAUSED_USER,
+                                VIR_DOMAIN_EVENT_SUSPENDED,
+                                VIR_DOMAIN_EVENT_SUSPENDED_PAUSED);
+}
+
+static int pvsResume(virDomainObjPtr privdom)
+{
+    return pvsCmdRun(PRLCTL, "resume", PVS_UUID(privdom), NULL);
+}
+
+static int
+pvsResumeDomain(virDomainPtr domain)
+{
+    return pvsDomainChangeState(domain,
+                                VIR_DOMAIN_PAUSED, "paused",
+                                pvsResume,
+                                VIR_DOMAIN_RUNNING, VIR_DOMAIN_RUNNING_UNPAUSED,
+                                VIR_DOMAIN_EVENT_RESUMED,
+                                VIR_DOMAIN_EVENT_RESUMED_UNPAUSED);
+}
+
+static int pvsStart(virDomainObjPtr privdom)
+{
+    return pvsCmdRun(PRLCTL, "start", PVS_UUID(privdom), NULL);
+}
+
+static int
+pvsDomainCreate(virDomainPtr domain)
+{
+    return pvsDomainChangeState(domain,
+                                VIR_DOMAIN_SHUTOFF, "stopped",
+                                pvsStart,
+                                VIR_DOMAIN_RUNNING, VIR_DOMAIN_EVENT_STARTED_BOOTED,
+                                VIR_DOMAIN_EVENT_STARTED,
+                                VIR_DOMAIN_EVENT_STARTED_BOOTED);
+}
+
+static int pvsKill(virDomainObjPtr privdom)
+{
+    return pvsCmdRun(PRLCTL, "stop", PVS_UUID(privdom), "--kill", NULL);
+}
+
+static int
+pvsDestroyDomain(virDomainPtr domain)
+{
+    return pvsDomainChangeState(domain,
+                                VIR_DOMAIN_RUNNING, "running",
+                                pvsKill,
+                                VIR_DOMAIN_SHUTOFF, VIR_DOMAIN_SHUTOFF_DESTROYED,
+                                VIR_DOMAIN_EVENT_STOPPED,
+                                VIR_DOMAIN_EVENT_STOPPED_DESTROYED);
+}
+
+static int pvsStop(virDomainObjPtr privdom)
+{
+    return pvsCmdRun(PRLCTL, "stop", PVS_UUID(privdom), NULL);
+}
+
+static int
+pvsShutdownDomain(virDomainPtr domain)
+{
+    return pvsDomainChangeState(domain,
+                                VIR_DOMAIN_RUNNING, "running",
+                                pvsStop,
+                                VIR_DOMAIN_SHUTOFF, VIR_DOMAIN_SHUTOFF_SHUTDOWN,
+                                VIR_DOMAIN_EVENT_STOPPED,
+                                VIR_DOMAIN_EVENT_STOPPED_SHUTDOWN);
+}
+
 static virDriver pvsDriver = {
     .no = VIR_DRV_PVS,
     .name = "PVS",
@@ -783,6 +927,11 @@ static virDriver pvsDriver = {
     .domainGetXMLDesc = pvsDomainGetXMLDesc,    /* 0.9.12 */
     .domainIsPersistent = pvsDomainIsPersistent,        /* 0.9.12 */
     .domainGetAutostart = pvsDomainGetAutostart,        /* 0.9.12 */
+    .domainSuspend = pvsPauseDomain,    /* 0.9.12 */
+    .domainResume = pvsResumeDomain,    /* 0.9.12 */
+    .domainDestroy = pvsDestroyDomain,  /* 0.9.12 */
+    .domainShutdown = pvsShutdownDomain, /* 0.9.12 */
+    .domainCreate = pvsDomainCreate,    /* 0.9.12 */
 };
 
 /**
diff --git a/src/pvs/pvs_driver.h b/src/pvs/pvs_driver.h
index b8ff055..30c6b36 100644
--- a/src/pvs/pvs_driver.h
+++ b/src/pvs/pvs_driver.h
@@ -61,5 +61,6 @@ typedef struct _pvsConn *pvsConnPtr;
 int pvsRegister(void);
 
 virJSONValuePtr pvsParseOutput(const char *binary, ...) ATTRIBUTE_NONNULL(1) ATTRIBUTE_SENTINEL;
+int pvsCmdRun(const char *binary, ...) ATTRIBUTE_NONNULL(1) ATTRIBUTE_SENTINEL;
 
 #endif
diff --git a/src/pvs/pvs_utils.c b/src/pvs/pvs_utils.c
index 0d74837..5a730ff 100644
--- a/src/pvs/pvs_utils.c
+++ b/src/pvs/pvs_utils.c
@@ -87,3 +87,21 @@ pvsParseOutput(const char *binary, ...)
     VIR_FREE(outbuf);
     return jobj;
 }
+
+/*
+ * Run prlctl command and check for errors
+ *
+ * Return value is 0 in case of success, else - -1
+ */
+int
+pvsCmdRun(const char *binary, ...)
+{
+    int ret;
+    va_list list;
+
+    va_start(list, binary);
+    ret = pvsDoCmdRun(NULL, binary, list);
+    va_end(list);
+
+    return ret;
+}
-- 
1.7.1




More information about the libvir-list mailing list