[libvirt] [PATCH] [libvirt-test-API] Use YABOOT instead of ISOLINUX to create bootable ISO.

[Guannan Ren]

On 05/03/2012 06:23 PM, Alex Jia wrote:
> On 05/03/2012 05:11 PM, Lin Qing wrote:
>> Yaboot is the bootloader of PowerPC  (ISOLINUX on AMD64/x86 systems, yaboot on PowerPC),
>> so should change the yaboot.conf firstly,then use mkiso command  to create bootable ISO.
> Whether we consider to rewrite it in python language and add it as a 
> function
> into utils module instead of a shell script, in addition, I don't like 
> 'if..else' in shell,
> if we will support other bootloader in the future, we must add a new 
> 'else' branch
> in ksiso.sh, it hasn't a better expansibility. I'd like to use python 
> 'getattr' as a dispatcher
> to deal with this kind of case. if we need to add a new bootloader 
> support, just need
> to add a new function/interface, you don't need to change original codes.
>

      Currently, the script is fine to work and easy to maintain.
      Python wrap will make it complex.
      let's just keep it for a while.

      Guannan Ren

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120503/e70ed0d8/attachment-0001.htm>