[libvirt] [PATCHv2 1/1] Assign spapr-vio address type to ibmvscsi controller

[Li Zhang]

On 05/11/2012 06:41 AM, Eric Blake wrote:
> On 05/10/2012 03:37 AM, Daniel P. Berrange wrote:
>> On Thu, May 10, 2012 at 04:39:48PM +0800, Li Zhang wrote:
>>> For pseries guest, the default controller model is
>>> ibmvscsi controller, this controller only can work
>>> on spapr-vio address.
>>>
>>> This patch is to assign spapr-vio address type to
>>> ibmvscsi controller.
>>>
>>> Signed-off-by: Li Zhang<zhlcindy at linux.vnet.ibm.com>
>>> ---
>>>   src/qemu/qemu_command.c |   14 +++++++++++---
>>>   1 file changed, 11 insertions(+), 3 deletions(-)
>>>
>
>>
>> ACK
>
> Needs a v2; 'make check' failed.  In particular, with:
> $ make -C tests check TESTS=qemuxml2argvtest VIR_TEST_DEBUG=1
>
> I see failures like:
>
> 148) QEMU XML-2-ARGV usb-redir                                         ...
> Offset 457
> Expect [bus=pci.0,addr=0x4.0x1]
> Actual [reg=0x2000]
>
> ... FAILED
> 149) QEMU XML-2-ARGV usb1-usb2
> ... libvir: QEMU error : XML error: spapr-vio address 0x2000 already in use
> FAILED
>
It is very strange.
This patch shouldn't change the address type of usb.
I run the test cases with the latest libvirt of master branch,
it seems there is only one vscsi test cases fails.
No the errors you mentioned.

65) QEMU XML-2-ARGV disk-scsi-vscsi                                   ...
Offset 223
Expect [bus=pci.0,addr=0x3 
                        ... FAILED
Actual [reg=0x2000

148) QEMU XML-2-ARGV usb-redir 
... OK
149) QEMU XML-2-ARGV usb1-usb2 
... OK

I think I need to make a little change for vscsi test case.
Can you tell me the libvirt version and Qemu version you are using?

Thanks.

> I don't know if the change in output is expected or a regression, so I'd
> feel a bit safer if we waited until after 0.9.12 to apply a fixed v2.
>


-- 
Best Regards
Li

IBM LTC, China System&Technology Lab, Beijing