[libvirt] [PATCH] Set a sensible default master start port for ehci companion controllers

[Daniel P. Berrange]

On Tue, May 15, 2012 at 07:22:52AM -0400, Oved Ourfalli wrote:
> You're right.
> I used an old VM and it didn't work well (VM from early dev phase for this feature).
> 
> I created a new one.
> First time I run it, it works.
> The second time, in which we pass the address (as we store it in the ovirt engine database), I get the following XML:
>                 <controller index="0" model="ich9-uhci1" type="usb">
>                         <master startport="0"/>
>                         <address  domain="0x0000"  function="0x2"  slot="0x04"  type="pci" bus="0x00"/>
>                 </controller>
>                 <controller index="0" model="ich9-ehci1" type="usb">
>                         <address  domain="0x0000"  function="0x2"  slot="0x04"  type="pci" bus="0x00"/>
>                 </controller>
>                 <controller index="0" model="ich9-uhci3" type="usb">
>                         <master startport="4"/>
>                         <address  domain="0x0000"  function="0x2"  slot="0x04"  type="pci" bus="0x00"/>
>                 </controller>
>                 <controller index="0" model="ich9-uhci2" type="usb">
>                         <master startport="2"/>
>                         <address  domain="0x0000"  function="0x2"  slot="0x04"  type="pci" bus="0x00"/>
>                 </controller>

It looks like you're not recording address correctly. You have put all devices
on the same function number here.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|