[libvirt] [PATCH] tests: run valgrind on real executables, not libtool wrappers
Daniel P. Berrange
berrange at redhat.com
Fri May 25 07:30:54 UTC 2012
On Thu, May 24, 2012 at 08:48:17PM -0600, Eric Blake wrote:
> * tests/Makefile.am (valgrind): Use libtool's ability to bypass
> libtool wrappers when running valgrind.
> ---
>
> I didn't think this was quite trivial enough to push without review.
> Now that tests use libtool, we want to be sure to run valgrind on
> the actual test, not on the bash shell that libtool uses to fire up
> the real test. I also tested that this works even when there is no
> libtool wrapper, such as when you disable modules for compilation.
>
> tests/Makefile.am | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index c7addde..24818b1 100644
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -244,7 +244,7 @@ TESTS_ENVIRONMENT = \
>
>
> valgrind:
> - $(MAKE) check VG="valgrind --quiet --leak-check=full --suppressions=$(srcdir)/.valgrind.supp"
> + $(MAKE) check VG="libtool --mode=execute valgrind --quiet --leak-check=full --suppressions=$(srcdir)/.valgrind.supp"
>
> sockettest_SOURCES = \
> sockettest.c \
ACK
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list