[libvirt] [PATCHv4 24/51] snapshot: prevent stranding snapshot data on domain destruction

Philipp Hahn hahn at univention.de
Mon Nov 5 08:24:26 UTC 2012

Hello Eric,

thank you for your answer; I had hoped to stop your from spending any further 
time ony this by my 2nd mail from October 26, because I found my thinko 
myself after reading some more code. Actually I was reading a patched 
version, where the patch broke it.

> > This behaviour is actually documented in
> > <http://libvirt.org/html/libvirt-libvirt.html#virDomainUndefineFlags>
> > (now that I know what I have to look at), but I was still surprised that
> > virDomainUndefineFlags(0) returned success on my inactive domain with
> > snapshots.
> That shouldn't happen - virDomainUndefineFlags(0) on an inactive domain
> should fail if the domain has snapshots.  Is this something you actually
> hit, and can you give me steps to reproduce?

The patch tried to work around the case of migrating VMs with snapshots, which 
is (as far as I know) still not possible, because there is no way to migrate 
the unknown size of snapshot xml data.
Our current workaround is to put /var/lib/libvirt/qemu/snapshot/ on a NFS and 
to patch libvirt not to delete the snapshot XML data von 
migrate --undefinesource.

So thanks again for spending your time; your mail was still much appreciated.

Philipp Hahn           Open Source Software Engineer      hahn at univention.de
Univention GmbH        be open.                       fon: +49 421 22 232- 0
Mary-Somerville-Str.1  D-28359 Bremen                 fax: +49 421 22 232-99
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20121105/f6c30310/attachment-0001.sig>

More information about the libvir-list mailing list