[libvirt] [v0.10.2-maint][PATCH] qemu: Always format CPU topology

Eric Blake eblake at redhat.com
Wed Nov 14 00:53:01 UTC 2012

On 11/13/2012 08:22 AM, Michal Privoznik wrote:
> From: Jiri Denemark <jdenemar at redhat.com>
> When libvirt cannot find a suitable CPU model for host CPU (easily
> reproducible by running libvirt in a guest), it would not provide CPU
> topology in capabilities XML either. Even though CPU topology is known
> and can be queried by virNodeGetInfo. With this patch, CPU topology will
> always be provided in capabilities XML regardless on the presence of CPU
> model.
> (cherry picked from commit f1c70100409562c3f402392aa667732e5f89a2c4)
> Conflicts:
>     src/qemu/qemu_capabilities.c
>     src/qemu/qemu_command.c
>     The new code uses capabilities caching.
> ---
> I am not sure about the correct process of this. So if there are some pointers ....

I think you're doing fine - since the backport was not trivial, asking
for review is appropriate.  And calling out both the cherry-pick id and
the changes from upstream is sufficient to understand what you were
doing.  About the only thing missing would be a reference to a bugzilla
that explains why you are doing the backport.


Eric Blake   eblake at redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 617 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20121113/3d2da532/attachment-0001.sig>

More information about the libvir-list mailing list