[libvirt] [PATCH] virsh: fix uninitialized variable in cmdSnapshotEdit

Christophe Fergeau cfergeau at redhat.com
Fri Nov 16 13:24:53 UTC 2012

On Fri, Nov 16, 2012 at 12:10:10PM +0100, Ján Tomko wrote:
> On 11/16/12 11:58, Christophe Fergeau wrote:
> > Shouldn't we call vshError with a different message in the !ret && !name case?
> > 
> > Christophe
> vshCommandOptDomain and vshLookupSnapshot already give reasonable error
> messages in that case. For non-existent domains:
> error: failed to get domain 'bla'
> error: Domain not found: no domain with matching name 'bla'
> And for snapshots:
> error: Domain snapshot not found: no domain snapshot with matching name
> 'bla'

Ah, all is good then, thanks!

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20121116/1ed3ee15/attachment-0001.sig>

More information about the libvir-list mailing list