[libvirt] [PATCH] Use virNetServerRun instead of custom main loop

Eric Blake eblake at redhat.com
Wed Nov 21 14:25:24 UTC 2012

On 11/21/2012 06:05 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange at redhat.com>
> The LXC controller code currently directly invokes the
> libvirt main loop code. The problem is that this misses
> the cleanup of virNetServerClient connections that
> virNetServerRun takes care of.
> The result is that when libvirtd is stopped, the
> libvirt_lxc controller process gets stuck in a I/O loop.
> When libvirtd is then started again, it fails to connect
> to the controller and thus kills of the entire domain.


> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> ---
>  src/lxc/lxc_controller.c | 33 ++++++++++++++-------------------
>  1 file changed, 14 insertions(+), 19 deletions(-)

ACK.  Always nice when using the right API to fix a bug also makes the
code smaller.

Eric Blake   eblake at redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20121121/90b677e1/attachment-0001.sig>

More information about the libvir-list mailing list