[libvirt] [PATCH] Correct include-password option for domdisplay

Martin Kletzander mkletzan at redhat.com
Wed Nov 21 16:13:22 UTC 2012

On 11/21/2012 05:06 PM, Ján Tomko wrote:
> On 11/21/12 16:37, Martin Kletzander wrote:
>> The 'virsh domdisplay' command is able to display the password
>> configured for spice, but it was missing for vnc type graphics.
>> This is just a simple patch for that to work properly.
>> ---
>>  tools/virsh-domain.c | 17 +++++++++++++++++
>>  1 file changed, 17 insertions(+)
> Wouldn't it be better to put the password before the host
> (vnc://:passwd@host:port) so that at least some clients (krdc from the
> few that I've tried) can understand the whole URI?
> Jan

TBH, I don't get this URI-styled remote display definitions because I
don't know what program can use those (universally, not just from
libvirt, I mean, and I haven't heard about krdc until now) and if there
is a recommended scheme for that, however this is how the parameter is
appended for spice connections and unless there is a scheme for that and
we can say "The previous version was a bug, this is how it should be", I
don't think we want rick breaking something.  OTOH this is just a virsh
call, not an API.


More information about the libvir-list mailing list