[libvirt] [PATCH v3 UPDATED 1/2] Qemu/Gluster: Add Gluster protocol as supported network disk formats.

[Eric Blake]

On 11/22/2012 01:49 AM, Harsh Bora wrote:

>>> +        transp = strstr(uri->scheme, "+");

strstr() for a single-byte needle is overkill.

>>> +        transp++;
>>
>> You could even squash the increment into the previous line :-)
> 
> That would give me:
> 
> qemu/qemu_command.c: In function 'qemuParseGlusterString':
> qemu/qemu_command.c:2048:18: error: lvalue required as left operand of
> assignment.

Not if you do:

transp = strchr(uri->scheme, '+') + 1;

-- 
Eric Blake   eblake at redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20121122/22716134/attachment-0001.sig>