[libvirt] [PATCHv2] qemu: Stop recursive detection of image chains when an image is missing

Peter Krempa pkrempa at redhat.com
Thu Nov 22 15:14:13 UTC 2012

On 11/22/12 16:02, Eric Blake wrote:
> On 11/22/2012 07:50 AM, Peter Krempa wrote:
>> Commit e0c469e58b93f852a72265919703cb6abd3779f8 that fixes the detection
>> of image chain wasn't complete. Iteration through the backing image
>> chain has to stop at the last existing image if some of the images are
>> missing otherwise the backing chain that is cached contains entries with
>> paths being set to NULL resulting to:
>> error: Unable to allow access for disk path (null): Bad address
>> Fortunately stat() is kind enough not to crash when it's presented with
>> a NULL argument. At least on Linux.
>> ---
>> Left meta->backingStoreRaw in place to mark broken chains, added a comment and a warning.
>> ---
>>   src/util/storage_file.c | 7 ++++++-
>>   1 file changed, 6 insertions(+), 1 deletion(-)
> ACK.

Pushed. Thanks.


More information about the libvir-list mailing list