[libvirt] [PATCH 0/4] qemu: add boot order support for redirected and host USB devices

Michal Privoznik mprivozn at redhat.com
Fri Nov 23 09:11:33 UTC 2012

On 21.11.2012 18:53, Eric Blake wrote:
> On 11/21/2012 10:43 AM, Michal Privoznik wrote:
>> On 20.11.2012 19:47, Ján Tomko wrote:
>>> Commit a4c19459aa8634c43b51e8138fb1d7eec4c17824 missed the functionality
>>> for redirected USB devices (fixed in 1/4), documentation and tests.
>>> https://bugzilla.redhat.com/show_bug.cgi?id=805414
>> I went ahead, ACKed and pushed this. However, meanwhile I've:
>> -split 2/4 patch into two smaller ones
>> -split huge line in 3/4
>> -fixed space at EOL in 4/4
> I think you should undo this fix, and match actual qemu output (even if
> it DOES have a trailing space), as that particular file should be exempt
> from whitespace enforcement.  (If git gives you problems for pushing a
> trailing space, ping me on IRC, and I'll help you figure out what to tweak).

Okay, I've fixed it. Surprisingly, there was no problem pushing the
previous version. In fact, we don't run the syntax-check rule on
tests/qemuhelpdata/* as I learned after digging into things.

Anyway, I've proposed patch on qemu upstream list:



More information about the libvir-list mailing list