[libvirt] [PATCH 0/3] qemu: QMP Capability Probing Fixes

Viktor Mihajlovski mihajlov at linux.vnet.ibm.com
Mon Nov 26 14:17:11 UTC 2012

QMP Capability probing will fail if the QEMU process cannot create the
monitor socket file in /var/lib/libvirt/qemu. This is the case if the 
configured QEMU user is not root, but QEMU is run under root to perfom
the probing.
The suggested solution is to run QEMU as qemu user for probing as well.

As it happens, this developed into a mini-series: it was necessary
to let libvirt handle the pid file as this is stored in root-owned
directory /var/run/libvirt/qemu. This prompted a race condition opening
a socket. Last but not least caps->version was not filled with QMP

Viktor Mihajlovski (3):
  qemu: Wait for monitor socket even without pid
  qemu: Fix QMP Capabability Probing Failure
  qemu: Add QEMU version computation to QMP probing

 src/qemu/qemu_capabilities.c | 89 ++++++++++++++++++++++++++++++++++----------
 src/qemu/qemu_capabilities.h |  7 +++-
 src/qemu/qemu_driver.c       |  4 +-
 src/qemu/qemu_monitor.c      |  2 +-
 4 files changed, 78 insertions(+), 24 deletions(-)


More information about the libvir-list mailing list