[libvirt] [PATCH 10/10] Fix leak of virNetworkPtr in LXC startup failure path

Daniel P. Berrange berrange at redhat.com
Tue Nov 27 17:06:29 UTC 2012


From: "Daniel P. Berrange" <berrange at redhat.com>

When starting an LXC guest with a virNetwork based NIC device,
if the network was not active, the virNetworkPtr device would
be leaked

Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
---
 src/lxc/lxc_process.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/lxc/lxc_process.c b/src/lxc/lxc_process.c
index 28eecec..514ef81 100644
--- a/src/lxc/lxc_process.c
+++ b/src/lxc/lxc_process.c
@@ -468,7 +468,6 @@ static int virLXCProcessSetupInterfaces(virConnectPtr conn,
                     virReportError(VIR_ERR_INTERNAL_ERROR,
                                    _("Network '%s' is not active."),
                                    def->nets[i]->data.network.name);
-                goto cleanup;
             }
 
             if (!fail) {
-- 
1.7.11.2




More information about the libvir-list mailing list