[libvirt] [PATCH v1 04/11] qemu: Introduce nbd-server-add command
eblake at redhat.com
Tue Nov 27 23:41:18 UTC 2012
> This will be used with new migration scheme.
> This patch creates basically just monitor stub
> functions. Wiring them into something useful
> is done in later patches.
> src/qemu/qemu_monitor.c | 21 +++++++++++++++++++++
> src/qemu/qemu_monitor.h | 2 ++
> src/qemu/qemu_monitor_json.c | 23 +++++++++++++++++++++++
> src/qemu/qemu_monitor_json.h | 2 ++
> 4 files changed, 48 insertions(+), 0 deletions(-)
> +qemuMonitorJSONNBDServerAdd(qemuMonitorPtr mon,
> + const char *deviceID)
> + int ret = -1;
> + virJSONValuePtr cmd;
> + virJSONValuePtr reply = NULL;
> + if (!(cmd = qemuMonitorJSONMakeCommand("nbd-server-add",
> + "s:device", deviceID,
> + NULL)))
According to qemu.git, 'writable' is optional, but if omitted, it
defaults to false. But doesn't storage migration require 'writable'
to be true in order for drive-mirror on the source to be able to
actually write into the destination?
[You may have dealt with this later in the series, but even if so,
I still think this stub should be doing something with "b:writable".]
More information about the libvir-list