[libvirt] [PATCH 2/4] Specify remote protocol for virDomainSendProcessSignal

[Peter Krempa]

On 11/28/12 12:31, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange at redhat.com>
>
> * src/remote/remote_protocol.x: message definition
> * src/remote/remote_driver.c: Register driver function
> * src/remote_protocol-structs: Test case
> ---
>   src/remote/remote_driver.c   |  1 +
>   src/remote/remote_protocol.x | 10 +++++++++-
>   src/remote_protocol-structs  |  7 +++++++
>   3 files changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
> index ec33698..9d04cc3 100644
> --- a/src/remote/remote_driver.c
> +++ b/src/remote/remote_driver.c
> @@ -6124,6 +6124,7 @@ static virDriver remote_driver = {
>       .domainMigrateFinish3 = remoteDomainMigrateFinish3, /* 0.9.2 */
>       .domainMigrateConfirm3 = remoteDomainMigrateConfirm3, /* 0.9.2 */
>       .domainSendKey = remoteDomainSendKey, /* 0.9.3 */
> +    .domainSendProcessSignal = remoteDomainSendProcessSignal, /* 0.9.8 */

s/0.9.8/1.0.1/

>       .domainBlockJobAbort = remoteDomainBlockJobAbort, /* 0.9.4 */
>       .domainGetBlockJobInfo = remoteDomainGetBlockJobInfo, /* 0.9.4 */
>       .domainBlockJobSetSpeed = remoteDomainBlockJobSetSpeed, /* 0.9.4 */
> diff --git a/src/remote/remote_protocol.x b/src/remote/remote_protocol.x
> index d6ac3c1..56ef20e 100644
> --- a/src/remote/remote_protocol.x
> +++ b/src/remote/remote_protocol.x
> @@ -1019,6 +1019,13 @@ struct remote_domain_send_key_args {
>       unsigned int flags;
>   };
>
> +struct remote_domain_send_process_signal_args {
> +    remote_nonnull_domain dom;
> +    unsigned int pid_value;
> +    unsigned int signum;
> +    unsigned int flags;
> +};
> +
>   struct remote_domain_set_vcpus_args {
>       remote_nonnull_domain dom;
>       unsigned int nvcpus;
> @@ -3026,7 +3033,8 @@ enum remote_procedure {
>
>       REMOTE_PROC_NETWORK_UPDATE = 291, /* autogen autogen priority:high */
>       REMOTE_PROC_DOMAIN_EVENT_PMSUSPEND_DISK = 292, /* autogen autogen */
> -    REMOTE_PROC_NODE_GET_CPU_MAP = 293 /* skipgen skipgen */
> +    REMOTE_PROC_NODE_GET_CPU_MAP = 293, /* skipgen skipgen */
> +    REMOTE_PROC_DOMAIN_SEND_PROCESS_SIGNAL = 294 /* autogen autogen priority:high */

When we will be implementing this for qemu with the guest agent we will 
need to set this to low priority. Is there a need to have this high 
priority due to LXC?

>
>       /*
>        * Notice how the entries are grouped in sets of 10 ?
> diff --git a/src/remote_protocol-structs b/src/remote_protocol-structs
> index 6fe7213..1256d89 100644
> --- a/src/remote_protocol-structs
> +++ b/src/remote_protocol-structs
> @@ -672,6 +672,12 @@ struct remote_domain_send_key_args {
>           } keycodes;
>           u_int                      flags;
>   };
> +struct remote_domain_send_process_signal_args {
> +        remote_nonnull_domain      dom;
> +        u_int                      pid_value;
> +        u_int                      signum;
> +        u_int                      flags;
> +};
>   struct remote_domain_set_vcpus_args {
>           remote_nonnull_domain      dom;
>           u_int                      nvcpus;
> @@ -2433,4 +2439,5 @@ enum remote_procedure {
>           REMOTE_PROC_NETWORK_UPDATE = 291,
>           REMOTE_PROC_DOMAIN_EVENT_PMSUSPEND_DISK = 292,
>           REMOTE_PROC_NODE_GET_CPU_MAP = 293,
> +        REMOTE_PROC_DOMAIN_SEND_PROCESS_SIGNAL = 294,
>   };
>