[libvirt] [PATCH] Allow comma separated list of shutdown/reboot modes with virsh

Eric Blake eblake at redhat.com
Fri Nov 30 19:19:02 UTC 2012

> > so we'd still need a post-processing path after virStringSplit.
> Well, which users of vshStringToArray actually need that feature ?

Commit 9d91a18 merged ,, into vshStringToArray out of a single caller,
vshParseSnapshotDiskspec; then commit 2cd4d8e added another caller
vshParseSnapshotMemspec.  All other callers don't need it.

> IIUC, the only ones are those which accept arbitrary user strings,
> which is only 1/2 users in virsh. The rest can use the new API
> with no practical loss in functionality, since they use fixed strings
> where ',' is not used.

That works for me.

Eric Blake   eblake at redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

More information about the libvir-list mailing list