[libvirt] [RFC PATCHv2 3/n] snapshot: make cloning of domain definition easier

Peter Krempa pkrempa at redhat.com
Tue Nov 20 15:05:43 UTC 2012


On 11/20/12 01:09, Eric Blake wrote:
> Upcoming patches for revert-and-clone branching of snapshots need
> to be able to copy a domain definition; make this step reusable.
>
> * src/conf/domain_conf.h (virDomainDefCopy): New prototype.
> * src/conf/domain_conf.c (virDomainObjCopyPersistentDef): Split...
> (virDomainDefCopy): ...into new function.
> (virDomainObjSetDefTransient): Use it.
> * src/libvirt_private.syms (domain_conf.h): Export it.
> * src/qemu/qemu_driver.c (qemuDomainRevertToSnapshot): Use it.
> ---
>   src/conf/domain_conf.c   | 37 +++++++++++++++++++++++--------------
>   src/conf/domain_conf.h   |  2 ++
>   src/libvirt_private.syms |  1 +
>   src/qemu/qemu_driver.c   | 14 ++------------
>   4 files changed, 28 insertions(+), 26 deletions(-)
>

ACK and you can push this out of order. I'll fix my series to take this 
improvement into account.

Peter




More information about the libvir-list mailing list