[libvirt] [RFC PATCHv2 3/n] snapshot: make cloning of domain definition easier
Eric Blake
eblake at redhat.com
Tue Nov 20 15:47:23 UTC 2012
On 11/20/2012 08:05 AM, Peter Krempa wrote:
> On 11/20/12 01:09, Eric Blake wrote:
>> Upcoming patches for revert-and-clone branching of snapshots need
>> to be able to copy a domain definition; make this step reusable.
>>
>> * src/conf/domain_conf.h (virDomainDefCopy): New prototype.
>> * src/conf/domain_conf.c (virDomainObjCopyPersistentDef): Split...
>> (virDomainDefCopy): ...into new function.
>> (virDomainObjSetDefTransient): Use it.
>> * src/libvirt_private.syms (domain_conf.h): Export it.
>> * src/qemu/qemu_driver.c (qemuDomainRevertToSnapshot): Use it.
>> ---
>> src/conf/domain_conf.c | 37 +++++++++++++++++++++++--------------
>> src/conf/domain_conf.h | 2 ++
>> src/libvirt_private.syms | 1 +
>> src/qemu/qemu_driver.c | 14 ++------------
>> 4 files changed, 28 insertions(+), 26 deletions(-)
>>
>
> ACK and you can push this out of order. I'll fix my series to take this
> improvement into account.
Done.
--
Eric Blake eblake at redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20121120/1e9a4b0e/attachment-0001.sig>
More information about the libvir-list
mailing list