[libvirt] [PATCH 04/10] Treat missing driver cgroup as fatal in LXC driver

Daniel P. Berrange berrange at redhat.com
Tue Nov 27 17:06:23 UTC 2012


From: "Daniel P. Berrange" <berrange at redhat.com>

The LXC driver relies on use of cgroups to kill off LXC processes
in shutdown. If cgroups aren't available, we're unable to kill
off processes, so we must treat lack of cgroups as a fatal startup
error.

Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
---
 src/lxc/lxc_cgroup.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/src/lxc/lxc_cgroup.c b/src/lxc/lxc_cgroup.c
index ed86b43..912233f 100644
--- a/src/lxc/lxc_cgroup.c
+++ b/src/lxc/lxc_cgroup.c
@@ -229,10 +229,6 @@ int virLXCCgroupSetup(virDomainDefPtr def)
 
     rc = virCgroupForDriver("lxc", &driver, 1, 0);
     if (rc != 0) {
-        /* Skip all if no driver cgroup is configured */
-        if (rc == -ENXIO || rc == -ENOENT)
-            return 0;
-
         virReportSystemError(-rc, "%s",
                              _("Unable to get cgroup for driver"));
         goto cleanup;
-- 
1.7.11.2




More information about the libvir-list mailing list