[libvirt] [PATCH 0/3] qemu: QMP Capability Probing Fixes

Daniel P. Berrange berrange at redhat.com
Wed Nov 28 14:58:35 UTC 2012


On Mon, Nov 26, 2012 at 03:17:11PM +0100, Viktor Mihajlovski wrote:
> QMP Capability probing will fail if the QEMU process cannot create the
> monitor socket file in /var/lib/libvirt/qemu. This is the case if the 
> configured QEMU user is not root, but QEMU is run under root to perfom
> the probing.
> The suggested solution is to run QEMU as qemu user for probing as well.
> 
> As it happens, this developed into a mini-series: it was necessary
> to let libvirt handle the pid file as this is stored in root-owned
> directory /var/run/libvirt/qemu. This prompted a race condition opening
> a socket. Last but not least caps->version was not filled with QMP
> probing. 
> 
> Viktor Mihajlovski (3):
>   qemu: Wait for monitor socket even without pid
>   qemu: Fix QMP Capabability Probing Failure
>   qemu: Add QEMU version computation to QMP probing

I pushed this series now.


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the libvir-list mailing list