[libvirt] [PATCH] Quote client identity in SASL whitelist log message

Daniel P. Berrange berrange at redhat.com
Fri Nov 30 19:16:28 UTC 2012


From: "Daniel P. Berrange" <berrange at redhat.com>

When seeing a message

 virNetSASLContextCheckIdentity:146 : SASL client admin not allowed in whitelist

it isn't immediately obvious that 'admin' is the identity
being checked. Quote the string to make it more obvious

Pushed under trivial rule

---
 src/rpc/virnetsaslcontext.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/rpc/virnetsaslcontext.c b/src/rpc/virnetsaslcontext.c
index 3001871..b6b68d5 100644
--- a/src/rpc/virnetsaslcontext.c
+++ b/src/rpc/virnetsaslcontext.c
@@ -163,7 +163,7 @@ int virNetSASLContextCheckIdentity(virNetSASLContextPtr ctxt,
     }
 
     /* Denied */
-    VIR_ERROR(_("SASL client %s not allowed in whitelist"), identity);
+    VIR_ERROR(_("SASL client identity '%s' not allowed in whitelist"), identity);
 
     /* This is the most common error: make it informative. */
     virReportError(VIR_ERR_SYSTEM_ERROR, "%s",
-- 
1.7.11.7




More information about the libvir-list mailing list