[libvirt] [PATCH 4/4] snapshot: merge pre-snapshot checks

[Peter Krempa]

On 09/11/12 02:01, Eric Blake wrote:
> Both system checkpoint snapshots and disk snapshots were iterating
> over all disks, doing a final sanity check before doing any work.
> But since future patches will allow offline snapshots to be either
> external or internal, it makes sense to share the pass over all
> disks, and then relax restrictions in that pass as new modes are
> implemented.  Future patches can then handle external disks when
> the domain is offline, then handle offline --disk-snapshot, and
> finally, combine with migration to file to gain a complete external
> system checkpoint snapshot of an active domain without using 'savevm'.
>
> * src/qemu/qemu_driver.c (qemuDomainSnapshotDiskPrepare)
> (qemuDomainSnapshotIsAllowed): Merge...
> (qemuDomainSnapshotPrepare): ...into one function.
> (qemuDomainSnapshotCreateXML): Update caller.
> ---
>   src/qemu/qemu_driver.c | 98 +++++++++++++++++++-------------------------------
>   1 file changed, 37 insertions(+), 61 deletions(-)

You will run into merge problems when rebasing this patch on top of the 
block-commit series (especialy the patch changing driver type string 
into enum). I merged it already and will post it so you don't have to do 
that.

Peter