[libvirt] [libvirt-tck PATCH] Add missing %end to kickstart file

[Guido Günther]

On Sat, Oct 20, 2012 at 02:21:18PM -0600, Eric Blake wrote:
> On 10/20/2012 02:08 PM, Guido Günther wrote:
> > ---
> >  conf/ks.cfg |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/conf/ks.cfg b/conf/ks.cfg
> > index 27e50e4..de82a26 100644
> > --- a/conf/ks.cfg
> > +++ b/conf/ks.cfg
> > @@ -27,3 +27,4 @@ poweroff
> >  @base
> >  @core
> >  @hardware-support
> > +%end
> 
> Can you point to a URL that documents why this is necessary?  For
> example, my quick google searching found
> https://www.centos.org/docs/4/html/rhel-sag-en-4/s1-kickstart2-file.html
> (yes, that looks quite old, but possibly still relevant), which doesn't
> mention %end, and also says that "Items that are not required can be
> omitted.".  In other words, I'm a bit reluctant to ack this without
> knowing why it is required for you.

http://fedoraproject.org/wiki/Anaconda/Kickstart#Creating_the_Kickstart_File

and

http://fedoraproject.org/wiki/Anaconda/Changes

which mentions that this was introduced in F14.

This is a difference between RHEL anaconda and Fedora anaconda as far as
I know.
Cheers
 -- Guido

> 
> -- 
> Eric Blake   eblake at redhat.com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>