[libvirt] [PATCHv9 3/9] blockjob: return appropriate event and info

[Peter Krempa]

On 10/23/12 04:10, Eric Blake wrote:
> Handle the new type of block copy event and info.  Of course,
> this patch does nothing until a later patch actually allows the
> creation/abort of a block copy job.  The new event is available
> in qemu 1.3, but not in RHEL 6.3; rather than doing polling
> ourselves to synthesize the event in RHEL 6.3, we just document
> that the event might not occur.

I'd drop this last sentence, the docs protect us from being blamed, and 
most of people running upstream won't encounter a rhel-patched qemu anyways.

>
> * include/libvirt/libvirt.h.in (VIR_DOMAIN_BLOCK_JOB_READY): New
> block job status.
> * src/libvirt.c (virDomainBlockRebase): Document the event.
> * src/qemu/qemu_monitor_json.c (eventHandlers): New event.
> (qemuMonitorJSONHandleBlockJobReady): New function.
> (qemuMonitorJSONGetBlockJobInfoOne): Translate new job type.
> (qemuMonitorJSONHandleBlockJobImpl): Handle new event and job type.
> * src/qemu/qemu_process.c (qemuProcessHandleBlockJob): Recognize
> the event to minimize snooping.
> * src/qemu/qemu_driver.c (qemuDomainBlockJobImpl): Snoop a successful
> info query to save effort on a pivot request.
> ---
>   include/libvirt/libvirt.h.in |  1 +
>   src/libvirt.c                |  7 ++++---
>   src/qemu/qemu_driver.c       |  6 ++++++
>   src/qemu/qemu_monitor_json.c | 19 +++++++++++++++++--
>   src/qemu/qemu_process.c      |  3 +++
>   5 files changed, 31 insertions(+), 5 deletions(-)
>

ACK.

Peter