[libvirt] [PATCHv9 7/9] blockjob: allow for existing files in block-copy

[Peter Krempa]

On 10/23/12 04:10, Eric Blake wrote:
> Support the REUSE_EXT flag, in part by copying sanity checks from
> snapshot code.  This code introduces a case of probing an external
> file for its type; such an action would be a security risk if the
> existing file is supposed to be raw but the contents resemble some
> other format; however, since the virDomainBlockRebase API has a
> flag to force treating the file as raw rather than probe, we can
> assume that probing is safe in all other instances.  Besides, if
> we don't probe or force raw, then qemu will.
>
> * src/qemu/qemu_driver.c (qemuDomainBlockRebase): Allow REUSE_EXT
> flag.
> (qemuDomainBlockCopy): Wire up flag, and add some sanity checks.
> ---
>   src/qemu/qemu_driver.c | 40 +++++++++++++++++++++++++++++++++++-----
>   1 file changed, 35 insertions(+), 5 deletions(-)
>

ACK. This one should be good in both cases.

PEter